Dsp-js sources, versions, naming, error handling

loic.jaouen · June 8, 2020, 2:40pm

so that’s exactly it:

dasch-swiss/knora-api/blob/0127dcae27e46bc3a4c9947282c30038c0a25d20/webapi/src/main/scala/org/knora/webapi/Settings.scala#L54


val internalKnoraApiPort: Int = config.getInt("app.knora-api.internal-port")
val internalKnoraApiBaseUrl: String = "http://" + internalKnoraApiHost + (if (internalKnoraApiPort != 80) ":" + internalKnoraApiPort else "")


// used for communication between the outside and the knora stack, e.g., browser
val externalKnoraApiProtocol: String = config.getString("app.knora-api.external-protocol")
val externalKnoraApiHost: String = config.getString("app.knora-api.external-host")
val externalKnoraApiPort: Int = config.getInt("app.knora-api.external-port")
val externalKnoraApiHostPort: String = externalKnoraApiHost + (if (externalKnoraApiPort != 80) ":" + externalKnoraApiPort else "")
val externalKnoraApiBaseUrl: String = externalKnoraApiProtocol + "://" + externalKnoraApiHost + (if (externalKnoraApiPort != 80) ":" + externalKnoraApiPort else "")


// If the external hostname is localhost, include the configured external port number in ontology IRIs for manual testing.
val externalOntologyIriHostAndPort: String = if (externalKnoraApiHost == "0.0.0.0" || externalKnoraApiHost == "localhost") {
    externalKnoraApiHostPort
} else {
    // Otherwise, don't include any port number in IRIs, so the IRIs will work both with http
    // and with https.
    externalKnoraApiHost
}


val salsah1BaseUrl: String = config.getString("app.salsah1.base-url")
val salsah1ProjectIconsBasePath: String = config.getString("app.salsah1.project-icons-basepath")

loic.jaouen · June 8, 2020, 2:43pm

when you workout the IRI, if the host is not localhost or 0.0.0.0, then you should not include the port.

t.schweizer · June 8, 2020, 6:03pm

does it work for you now?

loic.jaouen · June 9, 2020, 6:40am

Sorry Tobias, I don’t know if it works, I only looked up knora code.

I am implementing it now in knora-api-js-lib, then I’ll test and let you know.

I’ll be right back

loic.jaouen · June 9, 2020, 8:12am

here it is: https://github.com/dasch-swiss/knora-api-js-lib/pull/196

I tested and it works for me with that change.

(it took more time to try -and fail!- to configure the editor’s formatter to not change the whole file when saving)

editing test file now

t.schweizer · June 15, 2020, 6:20am

@loic.jaouen A new release of JS-lib is available: https://www.npmjs.com/package/@dasch-swiss/dsp-js/v/1.0.0-rc.2 It contains the fixes (see https://github.com/dasch-swiss/knora-api-js-lib/releases/tag/v1.0.0-rc.2).

Note that it’s called @dasch-swiss/dsp-js now (instead of @knora/api)

loic.jaouen · June 15, 2020, 6:44am

@t.schweizer cool, thanks for the notification. I have already the new name as right now I import a local version from a local registry. I will be happy to switch back to an official version

t.schweizer · June 15, 2020, 7:29am

@loic.jaouen Do you have access to the DSP version matrix?

loic.jaouen · June 15, 2020, 7:33am

DSP version matrix

what is it?

t.schweizer · June 15, 2020, 7:44am

https://docs.google.com/spreadsheets/d/1UWDFQ-2FYJw6SsKl2zznBldTPcl7Vvn3Z9ZbJfFz-UA/edit?pli=1#gid=0

If you cannot view it, please ask @subotic to give you access